[ 
https://issues.apache.org/jira/browse/FLUME-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216986#comment-13216986
 ] 

Peter Newcomb commented on FLUME-998:
-------------------------------------

I agree, and feel that the bug is with HDFSEventSink and any other sink that 
fails to return BACKOFF if process()'s first call to take() returns null.  I 
patched our version of HDFSEventSink to make it do so, but have so far failed 
to open a JIRA or post a patch for review simply due to a lack of time, and 
that I'd need to factor apart the many other patches I've made to HDFSEventSink 
as well.

I'll be doing all of that as soon as I find a round tuit.  :-)  If anyone's 
interested in looking at the full set of changes I've made before I get a 
chance to do so, I'd be happy to share the omnibus patch.  I think that all of 
the changes I've made are just for correctness, performance, and reliability, 
nothing really specific for our application or that actually changes its 
behavior.  I did recently incorporate Brock's changes from FLUME-985 (thanks!), 
so it's at least up-to-date with respect to that patch.

-peter
                
> JDBC Channel take does not block
> --------------------------------
>
>                 Key: FLUME-998
>                 URL: https://issues.apache.org/jira/browse/FLUME-998
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Priority: Critical
>             Fix For: v1.1.0
>
>
> Memory Channel takes block for a few seconds if there are no events to take. 
> This so the thread consuming events does not spin in a tight loop. JDBC 
> Channel does not block and returns null immediately, as such the thread 
> gettings events spins hard.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to