[
https://issues.apache.org/jira/browse/FLUME-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217469#comment-13217469
]
[email protected] commented on FLUME-989:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4047/#review5357
-----------------------------------------------------------
flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClientBuilder.java
<https://reviews.apache.org/r/4047/#comment11660>
Maybe you can provide a version of build which simply takes the 2 arguments
directly as well. You can simply set the values in the object and then call
this version of build().
flume-ng-sdk/src/main/java/org/apache/flume/api/client/DefaultAvroClient.java
<https://reviews.apache.org/r/4047/#comment11661>
I think close, append and appendBatch should be synchronized. If something
like this happens:
if(!isConnected) runs in one thread and then some other thread closes it,
the append call(in the first thread) is going to try to connect to a
transceiver that is closed, even though the append call was made before the
close. Similar case is true for appendBatch, also I think.
- Hari
On 2012-02-24 22:47:13, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4047/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-24 22:47:13)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Seeking early feedback on some additional APIs to make integrating with
Flume 1.x easier.
bq.
bq. Added the following APIs:
bq. - AvroClient: Friendly Java interface around the Avro API
bq. - AvroClientBuilder: Builder class to allow easy extension of AvroClient
capabilities in the future (i.e. SSL)
bq. - DefaultAvroClient: Implementation of the AvroClient interface
bq.
bq. Created this stuff in a flume-ng-sdk Maven submodule and moved the Event
interface to that submodule. flume-ng-core depends on flume-ng-sdk.
bq.
bq. I also modified AvroSink to use the AvroClient API instead of the bare
AvroSourceProtocol API directly.
bq.
bq.
bq. This addresses bug FLUME-989.
bq. https://issues.apache.org/jira/browse/FLUME-989
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/pom.xml d753fa1
bq. flume-ng-core/src/main/avro/flume.avdl 40da3ef
bq. flume-ng-core/src/main/java/org/apache/flume/Event.java a017705
bq. flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 5440631
bq. flume-ng-sdk/pom.xml PRE-CREATION
bq. flume-ng-sdk/src/main/avro/flume.avdl PRE-CREATION
bq. flume-ng-sdk/src/main/java/org/apache/flume/Event.java PRE-CREATION
bq. flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClient.java
PRE-CREATION
bq.
flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClientBuilder.java
PRE-CREATION
bq.
flume-ng-sdk/src/main/java/org/apache/flume/api/client/DefaultAvroClient.java
PRE-CREATION
bq. pom.xml d785762
bq.
bq. Diff: https://reviews.apache.org/r/4047/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Factor Flume Avro RPC interfaces out into separate Client SDK
> -------------------------------------------------------------
>
> Key: FLUME-989
> URL: https://issues.apache.org/jira/browse/FLUME-989
> Project: Flume
> Issue Type: Sub-task
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0
>
>
> Factor out the network RPC APIs so that there is a concise API boundary
> between user and developer APIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
