[ 
https://issues.apache.org/jira/browse/FLUME-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217830#comment-13217830
 ] 

Hudson commented on FLUME-1005:
-------------------------------

Integrated in flume-728 #116 (See 
[https://builds.apache.org/job/flume-728/116/])
    FLUME-1005. Fixing issues with flume-ng script

(Will McQueen via Arvind Prabhakar) (Revision 1294435)

     Result = FAILURE
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1294435
Files : 
* /incubator/flume/branches/flume-728/bin/flume-ng

                
> Several issues with flume-ng script
> -----------------------------------
>
>                 Key: FLUME-1005
>                 URL: https://issues.apache.org/jira/browse/FLUME-1005
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.1.0
>         Environment: RHEL 6.2 64-bit
>            Reporter: Will McQueen
>            Assignee: Will McQueen
>             Fix For: v1.1.0
>
>         Attachments: FLUME-1005.patch
>
>
> The changes in the script are described below:
> 1) Move FLUME_NODE_CLASS and FLUME_AVRO_CLIENT_CLASS after the sourcing of 
> flume-env.sh, since there's no reason that flume-env.sh should override these 
> 2 classes that are fundamental to Flume NG
> 2) The check for existence of flume-env.sh should include a check of whether 
> $FLUME_CONF_DIR is non-null. Otherwise there's a (very rare) chance that a 
> flume-env.sh file will be picked-up from root dir at '/flume-env.sh' if 
> FLUME_CONF_DIR isn't set.
> 3) spelling: " !" => "!"
> 4) Change display_help() to follow standard syntax of [COMMAND] [OPION]... 
> seen in man pages. Modify some indentation, based on new help entries
> 5) Remove all cases of using "--no-env,-E". This is not implemented.
> 6) Remove all cases of using "--data,-d". This is not implemented.
> 7) In display_help(), add node options and a node-specific help option. These 
> node options are what you would see in the help output if you ran the 
> Application.java class directly with "java Application -h"
> 8) In display_help(), add avro-client options. These client options are what 
> you would see in the help output if you ran "AvroCLIClient -h".
> 9) In run_node() and run_avro_client(), make FLUME_APPLICATION_CLASS local to 
> emphasize that its value isn't used in the caller's env. Also, remove the 
> check for JAVA_HOME since it's guaranteed that JAVA_HOME will have been set 
> by the time this function is called. In run_avro_client(), remove the 
> FLUME_CLASSPATH line since a similar check was already done earlier in the 
> same function.
> 10) Remove validate_env(), since --no-env,-E isn't implemented

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to