-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3831/#review5646
-----------------------------------------------------------


Thanks for the update Prasad. Looks like you rebased it to one version prior to 
the latest changes to context which is causing problems. Can you please refresh 
and rebase again?

Thanks

- Arvind


On 2012-02-22 18:26:46, Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3831/
> -----------------------------------------------------------
> 
> (Updated 2012-02-22 18:26:46)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> syslog source support for Flume 1.x
> 
> 
> This addresses bug FLUME-892.
>     https://issues.apache.org/jira/browse/FLUME-892
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/pom.xml d753fa1 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 
> PRE-CREATION 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 
> PRE-CREATION 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 
> PRE-CREATION 
>   
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/3831/diff
> 
> 
> Testing
> -------
> 
> regression tests
> Added new test for UDP soruce. tested the TCP source manually. Haven't found 
> a package that has the tcp syslog client. will add a testcase with custom tcp 
> client to test the source.
> 
> 
> Thanks,
> 
> Prasad
> 
>

Reply via email to