[
https://issues.apache.org/jira/browse/FLUME-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225386#comment-13225386
]
[email protected] commented on FLUME-1021:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4240/#review5740
-----------------------------------------------------------
Ship it!
+1. Please incorporate the following feedback and upload the patch to the Jira
for commit. Thanks for taking the time to do this.
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java
<https://reviews.apache.org/r/4240/#comment12490>
trailing whitespace.
flume-ng-core/src/main/java/org/apache/flume/Source.java
<https://reviews.apache.org/r/4240/#comment12491>
into configured {@link Channel}s (plural)
- Arvind
On 2012-03-08 11:45:11, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4240/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 11:45:11)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adding additional javadoc documentation for interfaces.
bq.
bq. The hope is to clarify various API contracts as well as to lower the
barrier to entry to the system for new developers.
bq.
bq. These are only Javadoc comments. No lines of executable code have been
changed.
bq.
bq.
bq. This addresses bug FLUME-1021.
bq. https://issues.apache.org/jira/browse/FLUME-1021
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/Channel.java b719220
bq. flume-ng-core/src/main/java/org/apache/flume/Context.java a6341a5
bq. flume-ng-core/src/main/java/org/apache/flume/CounterGroup.java 258805c
bq. flume-ng-core/src/main/java/org/apache/flume/Event.java a017705
bq. flume-ng-core/src/main/java/org/apache/flume/EventDeliveryException.java
d3dbb79
bq. flume-ng-core/src/main/java/org/apache/flume/EventDrivenSource.java
6ceaf69
bq. flume-ng-core/src/main/java/org/apache/flume/NamedComponent.java 1a65fe7
bq. flume-ng-core/src/main/java/org/apache/flume/PollableSource.java 663315a
bq. flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87
bq. flume-ng-core/src/main/java/org/apache/flume/Source.java ce2bbba
bq. flume-ng-core/src/main/java/org/apache/flume/SourceRunner.java ef65650
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java
104313b
bq.
flume-ng-core/src/main/java/org/apache/flume/source/EventDrivenSourceRunner.java
3baa6b3
bq.
bq. Diff: https://reviews.apache.org/r/4240/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Document API contracts and expected behavior in additional interfaces,
> including Source
> ---------------------------------------------------------------------------------------
>
> Key: FLUME-1021
> URL: https://issues.apache.org/jira/browse/FLUME-1021
> Project: Flume
> Issue Type: Improvement
> Components: Docs
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0
>
>
> We are lacking API documentation of several important interface contracts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
