----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4175/#review5775 -----------------------------------------------------------
Ship it! +1 looks great! I think we should attach this to the JIRA and get it committed. Will, I think we should open a separate JIRA to document the thread safety guarantees. Is that alright with you? Agreed that it's important to document, but this is already a win and the thread safety guarantees require careful attention and affect more areas than just the Sink-related interfaces. Best, Mike - Mike On 2012-03-09 07:51:16, Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4175/ > ----------------------------------------------------------- > > (Updated 2012-03-09 07:51:16) > > > Review request for Flume. > > > Summary > ------- > > An initial pass at documenting the interfaces. > Let me know if I missed anything relevant, or if you feel that this does not > correctly represent our expected behaviors. > > > This addresses bug FLUME-1019. > https://issues.apache.org/jira/browse/FLUME-1019 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java > 10f9f4e > flume-ng-core/src/main/java/org/apache/flume/Sink.java 3abeeb6 > flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java 11651ad > flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 2e80a56 > > Diff: https://reviews.apache.org/r/4175/diff > > > Testing > ------- > > No changes have been made to code > > > Thanks, > > Juhani > >
