[
https://issues.apache.org/jira/browse/FLUME-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226141#comment-13226141
]
[email protected] commented on FLUME-1019:
------------------------------------------------------
bq. On 2012-03-09 09:16:51, Mike Percy wrote:
bq. > +1 looks great! I think we should attach this to the JIRA and get it
committed.
bq. >
bq. > Will, I think we should open a separate JIRA to document the thread
safety guarantees. Is that alright with you? Agreed that it's important to
document, but this is already a win and the thread safety guarantees require
careful attention and affect more areas than just the Sink-related interfaces.
bq. >
bq. > Best,
bq. > Mike
Ok, agreed.
- Will
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4175/#review5775
-----------------------------------------------------------
On 2012-03-09 07:51:16, Juhani Connolly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4175/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-09 07:51:16)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. An initial pass at documenting the interfaces.
bq. Let me know if I missed anything relevant, or if you feel that this does
not correctly represent our expected behaviors.
bq.
bq.
bq. This addresses bug FLUME-1019.
bq. https://issues.apache.org/jira/browse/FLUME-1019
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java
10f9f4e
bq. flume-ng-core/src/main/java/org/apache/flume/Sink.java 3abeeb6
bq. flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java 11651ad
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 2e80a56
bq.
bq. Diff: https://reviews.apache.org/r/4175/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No changes have been made to code
bq.
bq.
bq. Thanks,
bq.
bq. Juhani
bq.
bq.
> Document Sink and related interfaces, defining expected behaviors
> -----------------------------------------------------------------
>
> Key: FLUME-1019
> URL: https://issues.apache.org/jira/browse/FLUME-1019
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0, v1.1.0
> Reporter: Juhani Connolly
> Assignee: Juhani Connolly
> Fix For: v1.1.0
>
> Attachments: FLUME-1019.2.patch
>
>
> Currently the Sink interface is undocumented and some of the other public
> interfaces that might be implemented by users for custom sinks/processors are
> poorly documented.
> In the process of documenting these interfaces, I hope to get input from
> others on what our expected behavior is.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
