[ 
https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231800#comment-13231800
 ] 

[email protected] commented on FLUME-1035:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/
-----------------------------------------------------------

(Updated 2012-03-17 02:03:05.530063)


Review request for Flume.


Changes
-------

There is a weird issue with Maven (bug?) where if one of my dependencies has a 
dependency set to "test", the distribution will not include it if I have the 
same dependency set to "compile". For the moment, the workaround is to specify 
slf4j-api as a dependency, along with slf4j-log4j12, even though they are only 
used in the tests.


Summary
-------

This patch fixes issues with unit test logging in the SDK.


This addresses bug FLUME-1035.
    https://issues.apache.org/jira/browse/FLUME-1035


Diffs (updated)
-----

  flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION 
  flume-ng-sdk/pom.xml d1c6adf 
  flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d 
  flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 
8c40aa4 

Diff: https://reviews.apache.org/r/4392/diff


Testing
-------


Thanks,

Mike


                
> slf4j error in flume sdk unit tests
> -----------------------------------
>
>                 Key: FLUME-1035
>                 URL: https://issues.apache.org/jira/browse/FLUME-1035
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.1.0, v1.2.0
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.1.0, v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not 
> include an implementation of SLF4J in the classpath while it uses JUL for 
> logging.
> We should make it consistent by using SLF4J and also provide an 
> implementation (Log4j) in the classpath for the SDK unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to