----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3962/#review6184 -----------------------------------------------------------
Ship it! +1. Changes look good Brock. Please update the patch by removing the *.orig files from it. Also, it will be great if you could wrap the source lines that exceed 80 char limit. No need for follow-up review, just attaching the patch to the Jira will be great. Thanks for all the help with this. - Arvind On 2012-03-21 05:13:45, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3962/ > ----------------------------------------------------------- > > (Updated 2012-03-21 05:13:45) > > > Review request for Flume. > > > Summary > ------- > > 1) Allows users to configure a restart flag and sleep interval for the > ExecSource should the command exit. > 2) Currently no one is reading standard error for the sub process. It is not > ignored like the documentation suggests. If the command generates enough > stderr to fill it's buffer, it will be blocked until someone reads that > buffer. A thread is added which by default reads and throws away stderr. If a > flag is turned on it will logstderr. This kind of flag can be very useful > when debugging why a command is not outputting the expected data. > > > This addresses bug FLUME-979. > https://issues.apache.org/jira/browse/FLUME-979 > > > Diffs > ----- > > > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java.orig > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 6035270 > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java.orig > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java b6b1181 > > Diff: https://reviews.apache.org/r/3962/diff > > > Testing > ------- > > A test for the restart flag and restartThrottle flag were added. All unit > tests pass. > > > Thanks, > > Brock > >
