-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4400/
-----------------------------------------------------------
(Updated 2012-03-22 04:00:33.408798)
Review request for Flume.
Changes
-------
Added in Mike's wording suggestions.
Will: yeah, I think that configuration is at the center of the whole threading
issue and we need to address that before we come around to individual
components.
Summary
-------
I went over the basic interfaces and added some javadoc for developers of new
components.
I am pretty concerned about the fact that pretty much everything is not thread
safe because off the lack of guarantees provided by some of the
interfaces(Configurable in particular).
A lot of existing components assume thread safety(which is somewhat given by
isolation of process() type methods to a single runner thread). Should we be
fixing these components, or making some more guarantees about when and how
configuration calls should be called(e.g. only callable on a stopped
component?)
This addresses bug Flume-1026.
https://issues.apache.org/jira/browse/Flume-1026
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/Channel.java 9d1c14c
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java 8806040
flume-ng-core/src/main/java/org/apache/flume/Sink.java 4a706cf
flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java ea6000b
flume-ng-core/src/main/java/org/apache/flume/Source.java f4e9481
flume-ng-core/src/main/java/org/apache/flume/Transaction.java 5b1fee5
flume-ng-core/src/main/java/org/apache/flume/conf/Configurable.java 0fa4839
Diff: https://reviews.apache.org/r/4400/diff
Testing
-------
Doc only patch
Thanks,
Juhani
