[ 
https://issues.apache.org/jira/browse/FLUME-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235448#comment-13235448
 ] 

[email protected] commented on FLUME-1020:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4360/#review6218
-----------------------------------------------------------

Ship it!


+1

Thanks for the patch Mike. Please attach it to the Jira. Also, it will be great 
if you can file a follow-up jira to remove the configuration constants from the 
system into their own separate class.

- Arvind


On 2012-03-22 08:06:39, Mike Percy wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4360/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-22 08:06:39)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is an initial pass at an implementation of HDFS security. I think it 
will probably work. Currently trying to get Kerberos to play nice with the 
cluster on my VM though, so I haven't successfully tested it yet. It still 
works when used on HDFS with security disabled. :)
bq.  
bq.  The only thing I don't like is in configure() when authentication fails I 
throw a FlumeException. I'll trace up and see how bad that would be but it 
seems likely to break something. Just logging the error is kind of a bummer as 
well, though ... need to ensure process() doesn't fill up the disk while 
spewing copious error messages into the logs. Maybe this is a use case for some 
kind of FatalException type thing.
bq.  
bq.  
bq.  This addresses bug FLUME-1020.
bq.      https://issues.apache.org/jira/browse/FLUME-1020
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bin/flume-ng 0796a5b 
bq.    flume-ng-core/src/main/java/org/apache/flume/tools/GetJavaProperty.java 
PRE-CREATION 
bq.    flume-ng-sinks/flume-hdfs-sink/pom.xml 1a35baf 
bq.    
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
 da82f7e 
bq.    pom.xml 227bca8 
bq.  
bq.  Diff: https://reviews.apache.org/r/4360/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mike
bq.  
bq.


                
> Implement Kerberos security for HDFS Sink
> -----------------------------------------
>
>                 Key: FLUME-1020
>                 URL: https://issues.apache.org/jira/browse/FLUME-1020
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.0.0
>            Reporter: Arvind Prabhakar
>            Assignee: Mike Percy
>         Attachments: FLUME-1020-9.patch
>
>
> Make flume HDFS sink work with secure clusters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to