[
https://issues.apache.org/jira/browse/FLUME-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235786#comment-13235786
]
[email protected] commented on FLUME-1043:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4446/#review6234
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-03-22 08:48:20, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4446/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-22 08:48:20)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Simple patch to use optional instead of compile scope for deps used in
unit tests in the SDK.
bq.
bq. We can't use test scope because it transitively affects core which causes
the jars to not be included in the overall assembly. Optional seems to work
fine.
bq.
bq.
bq. This addresses bug FLUME-1043.
bq. https://issues.apache.org/jira/browse/FLUME-1043
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sdk/pom.xml c8fb582
bq.
bq. Diff: https://reviews.apache.org/r/4446/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass, able to run binary build with sample config.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> SDK should mark slf4j deps as optional
> --------------------------------------
>
> Key: FLUME-1043
> URL: https://issues.apache.org/jira/browse/FLUME-1043
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.1.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.2.0
>
> Attachments: FLUME-1043.patch
>
>
> The flume SDK marks the slf4j deps as normal deps due to test scope
> transitively affecting flume core. However a better approach is to use
> optional, which has the effect we want (even though the semantics are a bit
> off).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
