----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4488/#review6376 -----------------------------------------------------------
Corrected the review field and attached the patch to the Jira. Thanks Brock! - Mike On 2012-03-26 21:46:26, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4488/ > ----------------------------------------------------------- > > (Updated 2012-03-26 21:46:26) > > > Review request for Flume. > > > Summary > ------- > > Created a static utility method to do the HexDump that the LoggerSink uses as > output for events. This lives in the core so that the SDK no longer has any > undeclared dependencies. > > > This addresses bug FLUME-1047. > https://issues.apache.org/jira/browse/FLUME-1047 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33 > flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java > PRE-CREATION > flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java 9099206 > flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java > 385cb7e > > Diff: https://reviews.apache.org/r/4488/diff > > > Testing > ------- > > mvn clean package > Unpacked tarball, ran: ./bin/flume-ng node -c conf -f > conf/flume-conf.properties.template -n foo > Lots of stuff dumped to stdout > > > Thanks, > > Mike > >
