[
https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238881#comment-13238881
]
[email protected] commented on FLUME-1047:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4488/
-----------------------------------------------------------
(Updated 2012-03-26 21:46:26.934475)
Review request for Flume.
Summary
-------
Created a static utility method to do the HexDump that the LoggerSink uses as
output for events. This lives in the core so that the SDK no longer has any
undeclared dependencies.
This addresses bug FLUME-1047.
https://issues.apache.org/jira/browse/FLUME-1047
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java
PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33
flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java
PRE-CREATION
flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java 9099206
flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java
385cb7e
Diff: https://reviews.apache.org/r/4488/diff
Testing
-------
mvn clean package
Unpacked tarball, ran: ./bin/flume-ng node -c conf -f
conf/flume-conf.properties.template -n foo
Lots of stuff dumped to stdout
Thanks,
Mike
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on
> apache commons into the client SDK. Between the time the initial patch was
> submitted and when it was committed the SimpleEvent class was factored into
> the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump
> functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
