[
https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242157#comment-13242157
]
[email protected] commented on FLUME-1074:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/#review6569
-----------------------------------------------------------
Prasad, good catch. These are the only two places with a Transaction.commit()
and without a catch (Exception e) clause.
Looks good to me.
- Mike
On 2012-03-30 05:33:54, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4568/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 05:33:54)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add exception handlers to rollback open transactions in error cases.
bq.
bq.
bq. This addresses bug FLUME-1074.
bq. https://issues.apache.org/jira/browse/FLUME-1074
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java
7e24e32
bq. flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8
bq.
bq. Diff: https://reviews.apache.org/r/4568/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. regression test run
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> AvroSink if any non-caught exception is thrown, an exception is thrown in
> finally clause
> ----------------------------------------------------------------------------------------
>
> Key: FLUME-1074
> URL: https://issues.apache.org/jira/browse/FLUME-1074
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before
> transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled
> exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN -
> you must either commit or rollback first
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:172)
> at
> org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
> at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
> at
> org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
> at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
> at java.lang.Thread.run(Thread.java:662)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
