> On 2012-03-30 03:02:19, Arvind Prabhakar wrote: > > Thanks for the patch Mike. This is a useful tool but I don't think it > > belongs to the SDK package. Perhaps we should repurpose it as a streaming > > client and push it under the client module?
This thing isn't reliable and focuses on throughput vs. reliability. It only blocks if one of the blocking queues between the Replicator and the Senders gets full. Also, it duplicates events multiple times and sends them all to the same destination... so from my perspective it's not very useful except as a load testing tool. Maybe we should check it into core instead of SDK? I just put it into SDK because that's the only dependency it has. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4564/#review6562 ----------------------------------------------------------- On 2012-03-29 23:44:21, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4564/ > ----------------------------------------------------------- > > (Updated 2012-03-29 23:44:21) > > > Review request for Flume. > > > Summary > ------- > > Example usage: (while true; do echo TEST; done) | ./flume-event-replicator > localhost 41414 10 100 > > > This addresses bug FLUME-1081. > https://issues.apache.org/jira/browse/FLUME-1081 > > > Diffs > ----- > > bin/flume-event-replicator PRE-CREATION > flume-ng-sdk/src/main/java/org/apache/flume/tools/EventReplicator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4564/diff > > > Testing > ------- > > Unit tests pass. I've done some manual testing of the tool. > > > Thanks, > > Mike > >
