----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 -----------------------------------------------------------
Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH="" One nit: whitespace at the end of line 107 - Mike On 2012-03-30 17:16:57, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4574/ > ----------------------------------------------------------- > > (Updated 2012-03-30 17:16:57) > > > Review request for Flume. > > > Summary > ------- > > Attached changes FLUME_CLASSPATH to append to the classpath like > HADOOP_CLASSPATH and HBASE_CLASSPATH do. > > > This addresses bug FLUME-1078. > https://issues.apache.org/jira/browse/FLUME-1078 > > > Diffs > ----- > > bin/flume-ng a31f171 > > Diff: https://reviews.apache.org/r/4574/diff > > > Testing > ------- > > Tested from the command line. > > > Thanks, > > Brock > >
