[
https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242737#comment-13242737
]
[email protected] commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-03-30 20:28:46, Mike Percy wrote:
bq. > Hi Brock, looks great except that it allows the shell environment to
specify $FLUME_CLASSPATH. The intention was to enforce that they come from
conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""
bq. >
bq. > One nit: whitespace at the end of line 107
bq.
bq. Brock Noland wrote:
bq. Related projects such as hadoop and hbase allow you to append to the
classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:
bq.
bq. env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command
bq.
bq. Is there a reason we don't want to be compatible?
The difference is that the "hadoop" command is a client command-line tool, but
the flume-ng script is primarily a startup script for the agent daemon. It's
bad practice to start daemons using environment variables since it's not
visible in "ps" and not reliably reproducible. So I would prefer not to support
it. If you feel that it's an important feature that makes flume easier to use
then I'm willing to let it go but I think it's a bad way to run a service.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6588
-----------------------------------------------------------
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like
HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/.
> FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
