[
https://issues.apache.org/jira/browse/FLUME-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244706#comment-13244706
]
[email protected] commented on FLUME-1084:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4615/
-----------------------------------------------------------
(Updated 2012-04-02 22:01:04.888338)
Review request for Flume.
Changes
-------
Removed the log4jproperties change.
Summary
-------
Netcat source does not close sockets when stop() is called. Fixed this.
This addresses bug FLUME-1084.
https://issues.apache.org/jira/browse/FLUME-1084
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda
Diff: https://reviews.apache.org/r/4615/diff
Testing
-------
All unit tests pass. Functional testing done.
Thanks,
Hari
> NetcatSource stop() function returns when client still connected to the
> source, and can still write to it.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FLUME-1084
> URL: https://issues.apache.org/jira/browse/FLUME-1084
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
>
> Previous behavior(commit: 48edaf2) :
> * netcat source runner.stop blocked till the accept handler exited when the
> nc client connected to it closed the connection
> (logs: [DEBUG -
> org.apache.flume.source.NetcatSource.stop(NetcatSource.java:208)] Waiting for
> handler service to stop)
> New behavior(commit: 39aba18):
> * netcat source runner.stop returns but a connected a client can still write
> to it, while a new source started up for the same agent due to
> reconfiguration. Note that a new client can startup on the same port as the
> old netcat source with no bind exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
