[
https://issues.apache.org/jira/browse/FLUME-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246602#comment-13246602
]
[email protected] commented on FLUME-1102:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4638/#review6695
-----------------------------------------------------------
Ship it!
+1
My understanding is the close() followed by open() takes care of the counters
getting reset, when the rotate happens and now talks to a new file. If that is
the case, it looks good.
- Hari
On 2012-04-04 18:51:44, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4638/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-04 18:51:44)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fix for rollInterval. Also added unit tests for the BucketWriter.
bq.
bq.
bq. This addresses bug FLUME-1102.
bq. https://issues.apache.org/jira/browse/FLUME-1102
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
3d00e64
bq.
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
PRE-CREATION
bq. flume-ng-sinks/flume-hdfs-sink/src/test/resources/log4j.properties
PRE-CREATION
bq.
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4638/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> HDFSEventSink rollInterval is broken
> ------------------------------------
>
> Key: FLUME-1102
> URL: https://issues.apache.org/jira/browse/FLUME-1102
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
>
> rollInterval doesn't work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
