[
https://issues.apache.org/jira/browse/FLUME-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248151#comment-13248151
]
[email protected] commented on FLUME-1105:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4667/#review6736
-----------------------------------------------------------
Ship it!
lgtm.
just a minor comment about the log message.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
<https://reviews.apache.org/r/4667/#comment14686>
It would be better to make it an info message than warning.
- Prasad
On 2012-04-06 04:40:53, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4667/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-06 04:40:53)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Created a configuration option which controls the creation of foreign key
constraints for the jdbc channel. The value of this option is true by default,
which implies that the FK constraints will be created. To disable these
constraints, the user must explicitly turn it off via configuration.
bq.
bq.
bq. This addresses bug FLUME-1105.
bq. https://issues.apache.org/jira/browse/FLUME-1105
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
1310152
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
1310152
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
1310152
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java
1310152
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java
1310152
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
1310152
bq.
bq. Diff: https://reviews.apache.org/r/4667/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran full tests. Also manually verified that the fk constraints could be
created or not via the configuration option.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Allow the optional disabling of foreign keys
> --------------------------------------------
>
> Key: FLUME-1105
> URL: https://issues.apache.org/jira/browse/FLUME-1105
> Project: Flume
> Issue Type: Sub-task
> Components: Channel
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1105-1.patch
>
>
> The JDFC Channel uses Foreign Key constraints by default. There should be an
> option to create the schema without such constraints if desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
