[
https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249321#comment-13249321
]
[email protected] commented on FLUME-1107:
------------------------------------------------------
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 27
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line27>
bq. >
bq. > for readability:
bq. > SYSPRO=>SYSPROP
bq. > (here and in all referenced locations)
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 33
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line33>
bq. >
bq. > SYSPRO=>SYSPROP
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 69
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line69>
bq. >
bq. > For readability:
bq. > PROPERTIES=>PROPS
bq. > (here and all referring locations)
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 75
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line75>
bq. >
bq. > PROPERTIES=>PROPS
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 121
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line121>
bq. >
bq. > For readability:
bq. > CONNECTION=>CONNECTIONS
bq. > ...here and in all referring locations
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java,
line 126
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line126>
bq. >
bq. > CONNECTION=>CONNECTIONS
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java,
line 542
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line542>
bq. >
bq. > Long=>long
bq. > new form => new short form
done.
bq. On 2012-04-07 12:35:09, Will McQueen wrote:
bq. >
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java,
line 550
bq. > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line550>
bq. >
bq. > @param defaultValue default value, null if no default
done.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6768
-----------------------------------------------------------
On 2012-04-07 08:32:03, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4677/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-07 08:32:03)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modified the implementation to deprecate the old form of configuration
keys for JDBC channel. The new form takes precedence if both types are present.
bq.
bq.
bq. This addresses bug FLUME-1107.
bq. https://issues.apache.org/jira/browse/FLUME-1107
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
1310683
bq.
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
1310683
bq.
bq. Diff: https://reviews.apache.org/r/4677/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran JDBC channel unit tests with the deprecated old form of configuration
keys. Updated the tests to use the new form and tested as well.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
> Key: FLUME-1107
> URL: https://issues.apache.org/jira/browse/FLUME-1107
> Project: Flume
> Issue Type: Sub-task
> Components: Channel
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which
> serves no purpose as the configuration is already namespace isolated within
> the configuration system.
> For example, to set the capacity of the channel named "jdbcchannel", the
> configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity =
> 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
