----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4681/#review6807 -----------------------------------------------------------
Ship it! +1 @Brock will keep an eye on the issue and if it resurfaces after this fix, will open a new jira. - Arvind On 2012-04-09 06:54:55, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4681/ > ----------------------------------------------------------- > > (Updated 2012-04-09 06:54:55) > > > Review request for Flume and Arvind Prabhakar. > > > Summary > ------- > > The sink runner's stop method first calls stop() to underlying sink and then > shuts down the PollingRunner thread. If that thread is in middle of process, > it leads to race conditions in the sink's process() and stop(). > Rather than making all sinks to handle concurrently process() and stop(), its > safer to shutdown the runner thread first and then stop the sink. > > > This addresses bug FLUME-1110. > https://issues.apache.org/jira/browse/FLUME-1110 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java e73c09b > > Diff: https://reviews.apache.org/r/4681/diff > > > Testing > ------- > > full regression test run > > > Thanks, > > Prasad > >
