----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/#review6992 -----------------------------------------------------------
Ship it! - Brock On 2012-04-17 21:29:29, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4759/ > ----------------------------------------------------------- > > (Updated 2012-04-17 21:29:29) > > > Review request for Flume. > > > Summary > ------- > > We shouldn't allow the flume-env.sh variables to override command-line > parameters. This patch fixes that issue. > This also adds support for a --dryrun parameter in order to test the > variations and cleans up the flume-env.sh.template file a little bit. > The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, > JAVA_OPTS > > > This addresses bug FLUME-1125. > https://issues.apache.org/jira/browse/FLUME-1125 > > > Diffs > ----- > > bin/flume-ng 145db32 > conf/flume-env.sh.template 0388ef9 > > Diff: https://reviews.apache.org/r/4759/diff > > > Testing > ------- > > Manually tested various combinations. > > > Thanks, > > Mike > >
