----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4622/#review7122 -----------------------------------------------------------
Thanks for the patch Inder, changes look good Inder. Some minor feedback below. trunk/bin/flume-ng <https://reviews.apache.org/r/4622/#comment15739> Please make sure you are space/indent aligned. Also suggest using <file> instead of <headerFile> for brevity: --headerFile,-R <file> text file containing headers trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15737> convention: catch on the same line as closing brace: ... } catch (Exception e) { ... trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15738> convention: terminating paranthesis should be on the same line. If line length is more than 80 char, please use a shorter name for the entry or consider wrapping the line into two lines. - Arvind On 2012-04-20 08:50:23, Inder Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4622/ > ----------------------------------------------------------- > > (Updated 2012-04-20 08:50:23) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Patch to address FLUME 1096. Please review and share your thoughts. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1096. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1096 > > > Diffs > ----- > > trunk/bin/flume-ng 1328221 > > trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java > 1328221 > > Diff: https://reviews.apache.org/r/4622/diff > > > Testing > ------- > > 1. Configured flume agent to publish data in /data/flume/%D > 2. ran the avroClient to stream some data. > 3. Things looked ok. Data was available in HDFS. > > > Thanks, > > Inder > >
