> On 2012-04-19 07:02:57, Juhani Connolly wrote: > > pom.xml, line 41 > > <https://reviews.apache.org/r/4502/diff/4-6/?file=101779#file101779line41> > > > > These changes don't look like they belong here... Maybe your patch was > > based against the wrong version? > > Hari Shreedharan wrote: > Hi Juhani, > > Thanks for the feedback. This appears in the diff because I rebased the > patch on trunk (sorry, I may have forgotten to mention this). Please see : > https://github.com/apache/flume/blob/trunk/pom.xml(lines 41 to 46). Thats the > reason you see it as added when you diff between patch versions 4 and 6. This > patch should be applied to trunk.
right, my bad! Everything looks good to me with the addition of the other memory channel. I'll check over individual components as soon as this is committed - Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review7018 ----------------------------------------------------------- On 2012-04-19 17:20:28, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4502/ > ----------------------------------------------------------- > > (Updated 2012-04-19 17:20:28) > > > Review request for Flume. > > > Summary > ------- > > Main config component. > > > This addresses bug FLUME-1052. > https://issues.apache.org/jira/browse/FLUME-1052 > > > Diffs > ----- > > flume-ng-configuration/pom.xml PRE-CREATION > flume-ng-configuration/src/main/java/org/apache/flume/Context.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java > PRE-CREATION > flume-ng-core/pom.xml b9f1e12 > flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb > flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 > flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 > flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java > 800f471 > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java > 511fc65 > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java > d8419e8 > > flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java > 963a6a3 > > flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java > 84492e5 > flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java > b89dfa0 > flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java > 257bab3 > flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 > flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java > 6160a17 > flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 > > flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java > a610e6f > flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e > flume-ng-dist/pom.xml 642e681 > flume-ng-dist/src/main/assembly/dist.xml 917ac02 > flume-ng-dist/src/main/assembly/src.xml 3b24b39 > > flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java > d66f6d1 > > flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java > 1f0e8c6 > pom.xml ed8092d > > Diff: https://reviews.apache.org/r/4502/diff > > > Testing > ------- > > Functional testing done. > > > Thanks, > > Hari > >
