[
https://issues.apache.org/jira/browse/FLUME-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259834#comment-13259834
]
[email protected] commented on FLUME-1127:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4762/#review7151
-----------------------------------------------------------
Ship it!
+1
Changes look good Mike. Please open a follow-up Jira to enhance the test case
so that it fails in case the compression does not kick in.
- Arvind
On 2012-04-18 01:58:33, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4762/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 01:58:33)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add configuration support to AbstractAvroEventSerializer for Avro sync
interval and compression support.
bq.
bq.
bq. This addresses bug FLUME-1127.
bq. https://issues.apache.org/jira/browse/FLUME-1127
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/AbstractAvroEventSerializer.java
a0884b2
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventSerializerConfigurationConstants.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java
ff381be
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java
0cbf08a
bq.
bq. Diff: https://reviews.apache.org/r/4762/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit tests. Also did manual verification of the compression codec on
the output files.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Add configuration support to AbstractAvroEventSerializer for Avro sync
> interval and compression support
> -------------------------------------------------------------------------------------------------------
>
> Key: FLUME-1127
> URL: https://issues.apache.org/jira/browse/FLUME-1127
> Project: Flume
> Issue Type: Improvement
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
