----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4507/#review7162 -----------------------------------------------------------
Ship it! Looks good. Being super-picky I would say you could maybe move the port and batchsize null checks next to the places where they are actually set for code clarity. - Juhani On 2012-03-27 06:25:18, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4507/ > ----------------------------------------------------------- > > (Updated 2012-03-27 06:25:18) > > > Review request for Flume. > > > Summary > ------- > > Avrosink conf > > > This addresses bug FLUME-1057. > https://issues.apache.org/jira/browse/FLUME-1057 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/AvroSinkConfiguration.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 3edc563 > > Diff: https://reviews.apache.org/r/4507/diff > > > Testing > ------- > > > Thanks, > > Hari > >
