[
https://issues.apache.org/jira/browse/FLUME-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260168#comment-13260168
]
[email protected] commented on FLUME-1058:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4508/#review7163
-----------------------------------------------------------
Functionally fine, just a couple of niggles
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/ExecSourceConfiguration.java
<https://reviews.apache.org/r/4508/#comment15817>
This should probably be a constant
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/ExecSourceConfiguration.java
<https://reviews.apache.org/r/4508/#comment15816>
I'm pretty sure that now we have a dedicated class for the configuration
we don't need a subclass to hold the constants?
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
<https://reviews.apache.org/r/4508/#comment15818>
For consistency I think this should go into the configuration and throw a
ConfigurationException
- Juhani
On 2012-03-27 06:26:30, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4508/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 06:26:30)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. ExecSource configuration
bq.
bq.
bq. This addresses bug FLUME-1058.
bq. https://issues.apache.org/jira/browse/FLUME-1058
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/ExecSourceConfiguration.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
dbf79e0
bq.
flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java
73c985e
bq.
bq. Diff: https://reviews.apache.org/r/4508/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Exec source configuration
> -------------------------
>
> Key: FLUME-1058
> URL: https://issues.apache.org/jira/browse/FLUME-1058
> Project: Flume
> Issue Type: Sub-task
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
