----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4849/#review7178 -----------------------------------------------------------
Hari, even though this is not related to your change, it will be better if you can address the following as well with your patch: flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java <https://reviews.apache.org/r/4849/#comment15837> This seems to be incorrect. flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java <https://reviews.apache.org/r/4849/#comment15838> convention nit: please place else on the same line as the preceding curly brace: ... } else { ... - Arvind On 2012-04-24 00:56:30, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4849/ > ----------------------------------------------------------- > > (Updated 2012-04-24 00:56:30) > > > Review request for Flume and Arvind Prabhakar. > > > Summary > ------- > > Minor fix for seq source not working with multiplexing channel selector. > > > This addresses bug FLUME-1142. > https://issues.apache.org/jira/browse/FLUME-1142 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java > 924fc05 > > Diff: https://reviews.apache.org/r/4849/diff > > > Testing > ------- > > Ran a node with seq source and multiplexing channel selector. > > > Thanks, > > Hari > >
