[
https://issues.apache.org/jira/browse/FLUME-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264623#comment-13264623
]
[email protected] commented on FLUME-1134:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4839/#review7369
-----------------------------------------------------------
Ship it!
+1
Looks good!
- Hari
On 2012-04-29 14:54:30, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4839/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-29 14:54:30)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently we use an ScheduledExecutorService which eats any throwable from
MonitoredRunnable. The change is to log the error and then propagate in case
the caller implementation should change.
bq.
bq.
bq. This addresses bug FLUME-1134.
bq. https://issues.apache.org/jira/browse/FLUME-1134
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
2935e64
bq.
bq. Diff: https://reviews.apache.org/r/4839/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Logging only change.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> LifecycleSupervisor.MonitorRunnable does not log runtime errors
> ---------------------------------------------------------------
>
> Key: FLUME-1134
> URL: https://issues.apache.org/jira/browse/FLUME-1134
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-1134-0.patch, FLUME-1134-1.patch
>
>
> LifecycleSupervisor.MonitorRunnable does not log RuntimeException/Error but
> the class we use to execute these runnables eats the exceptions. The run
> method should be wrapped in a try catch and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
