[
https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266264#comment-13266264
]
[email protected] commented on FLUME-1132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4838/#review7457
-----------------------------------------------------------
Ship it!
+1 Changes look good. A couple of nits noted below.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/4838/#comment16464>
nit: the callWithTimeoutLogError adds a prefix to the log message as "Error
calling " + name. This translates to a message in this case like:"Error calling
Calling flush on ...". Suggest removing the redundant words here and keeping
the name to "flush on " + callableWriter.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/4838/#comment16465>
nit: "close on " + e.getKey()
- Arvind
On 2012-04-22 23:17:45, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4838/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-22 23:17:45)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Message is logged a large volume of times and is incorrect.
bq.
bq.
bq. This addresses bug FLUME-1132.
bq. https://issues.apache.org/jira/browse/FLUME-1132
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
1b61cad
bq.
bq. Diff: https://reviews.apache.org/r/4838/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Logging only change
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
> Key: FLUME-1132
> URL: https://issues.apache.org/jira/browse/FLUME-1132
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort
> on ...". This is incorrect as it's actually calling flush and is logged a
> tremendous number of times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
