[
https://issues.apache.org/jira/browse/FLUME-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266696#comment-13266696
]
[email protected] commented on FLUME-1128:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4791/#review7472
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-04-18 18:50:58, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4791/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 18:50:58)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As of now, this does not cause any issues. But if we were to increase the
number of threads for some reason(say we add a 2nd configuration file), then it
is possible for a 2nd conf poller to start up before the first one is done. So
making this code clearer, by making it single threaded executor and also
calling fixed delay rather than fixed rate.
bq.
bq.
bq. This addresses bug FLUME-1128.
bq. https://issues.apache.org/jira/browse/FLUME-1128
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java
64f4e35
bq.
bq. Diff: https://reviews.apache.org/r/4791/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests pass. Functional testing done.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Conf poller should use schedule with fixed delay
> -------------------------------------------------
>
> Key: FLUME-1128
> URL: https://issues.apache.org/jira/browse/FLUME-1128
> Project: Flume
> Issue Type: Bug
> Components: Node
> Affects Versions: v1.1.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Fix For: v1.2.0
>
> Attachments: FLUME-1128.patch
>
>
> Not a major issue, but we should be polling with fixed delay, not at fixed
> rate. Since we have only one thread, even the scheduleAtFixedRate works the
> same way, but just making sure the code is cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
