[
https://issues.apache.org/jira/browse/FLUME-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266766#comment-13266766
]
[email protected] commented on FLUME-1146:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4871/#review7476
-----------------------------------------------------------
Thanks for the patch Hari. I am not sure if this is working though. Here is the
dependencies generated after applying this patch for log4jappender:
avro-1.6.1.jar
avro-ipc-1.6.1.jar
commons-codec-1.3.jar
commons-collections-3.2.1.jar
commons-io-2.1.jar
commons-lang-2.4.jar
commons-logging-1.1.1.jar
commons-pool-1.5.4.jar
flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar
httpclient-4.0.1.jar
httpcore-4.0.1.jar
jetty-6.1.26.jar
jetty-util-6.1.26.jar
jsr305-1.3.9.jar
log4j-1.2.16.jar
netty-3.2.6.Final.jar
paranamer-2.3.jar
servlet-api-2.5-20081211.jar
servlet-api-2.5.jar
snappy-java-1.0.4.1.jar
velocity-1.7.jar
Some of these are not needed, and some of the needed ones are getting excluded.
Here is what I feel are the required dependencies for the log4j appender:
avro-1.6.1.jar
avro-ipc-1.6.1.jar
flume-ng-log4jappender-1.2.0-incubating-SNAPSHOT.jar
flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar
jackson-core-asl-1.9.3.jar
jackson-mapper-asl-1.9.3.jar
log4j-1.2.16.jar
netty-3.2.6.Final.jar
slf4j-api-1.6.1.jar
As you can see the jackson and slf4j are missing, while a host of other libs
are getting included that are not needed.
flume-ng-dist/src/main/assembly/dist.xml
<https://reviews.apache.org/r/4871/#comment16523>
This manual exclusion does not make sense as it will break if the upstream
dependencies changes. Right now it is excluding jackson libs which are required
for the appender to work.
flume-ng-dist/src/main/assembly/dist.xml
<https://reviews.apache.org/r/4871/#comment16522>
nit: please call it lib instead of dep
- Arvind
On 2012-04-26 02:52:24, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4871/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 02:52:24)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Move log4jappender to another folder.
bq.
bq.
bq. This addresses bug FLUME-1146.
bq. https://issues.apache.org/jira/browse/FLUME-1146
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-dist/src/main/assembly/dist.xml 98f48fb
bq.
bq. Diff: https://reviews.apache.org/r/4871/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Standalone clients like log4jappender should go into a different folder in
> the distribution
> -------------------------------------------------------------------------------------------
>
> Key: FLUME-1146
> URL: https://issues.apache.org/jira/browse/FLUME-1146
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Attachments: FLUME-1146-1.patch, FLUME-1146.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
