[
https://issues.apache.org/jira/browse/FLUME-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274507#comment-13274507
]
[email protected] commented on FLUME-1183:
------------------------------------------------------
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java,
line 103
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108613#file108613line103>
bq. >
bq. > There are some missing @Override's here, correct?
Yep. Adding it.
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java,
line 201
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108613#file108613line201>
bq. >
bq. > Shouldn't we flush the table after batchSize has been processed?
Actually, it is ok not to. This is because we use Htable.batch(), which flushes
immediately. Even the increment is supposed to send individual increments
immediately to HBase. Only puts are affected by flushes.
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java,
line 164
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108613#file108613line164>
bq. >
bq. > cf.getBytes(Charsets.UTF8) doesn't throw a checked exception.
Done.
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java,
line 216
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108613#file108613line216>
bq. >
bq. > Since we have a pending exception to throw, how about logging any
Exception from rollback? That is the tack I took in the ChannelProcessor.
Done.
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleHbaseEventSerializer.java,
line 96
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108615#file108615line96>
bq. >
bq. > Same as above, an alternative getBytes() method does not throw the
checked exception.
Done.
bq. On 2012-05-12 15:42:20, Brock Noland wrote:
bq. >
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java,
line 87
bq. > <https://reviews.apache.org/r/5073/diff/3/?file=108613#file108613line87>
bq. >
bq. > Doesn't look like you can set this?
Seems like the last update, I removed the configurability of this - will put
it back.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5073/#review7828
-----------------------------------------------------------
On 2012-05-11 20:29:38, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5073/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-11 20:29:38)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Hbase sink.
bq.
bq.
bq. This addresses bug FLUME-1183.
bq. https://issues.apache.org/jira/browse/FLUME-1183
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng 0108997
bq. flume-ng-dist/pom.xml 5bdcfe7
bq. flume-ng-sinks/flume-ng-hbase-sink/pom.xml PRE-CREATION
bq.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java
PRE-CREATION
bq.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HbaseEventSerializer.java
PRE-CREATION
bq.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleHbaseEventSerializer.java
PRE-CREATION
bq.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleRowKeyGenerator.java
PRE-CREATION
bq.
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSink.java
PRE-CREATION
bq. flume-ng-sinks/pom.xml acb3087
bq. pom.xml 8c11a2d
bq.
bq. Diff: https://reviews.apache.org/r/5073/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests added
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Implement an HBase Sink which supports table level access
> ---------------------------------------------------------
>
> Key: FLUME-1183
> URL: https://issues.apache.org/jira/browse/FLUME-1183
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> This is what I intend to do:
> * Insert the row key from event headers. Pick the column family and column
> from configuration, not from headers.
> * Allow configuration to specify default for row key. If no row key exists in
> header, then take the default value from the configuration. I don't want to
> dump everything into the table with the same row key.
> * I don't intend to support multiple tables, column families or columns in
> the same sink. We can use multiplexing channel selector to use different
> sinks for different tables/columns.
> I know the existence of another jira for porting the HBase sink from OG, but
> didn't see any activity for a while on that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
