-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5161/
-----------------------------------------------------------

(Updated 2012-05-18 17:33:45.327838)


Review request for Flume and Juhani Connolly.


Changes
-------

Incorporated the review feedback and modified one of the testcase that had a 
very strict assertion for a state that had high probability of happening.

Ran all the tests.


Summary
-------

Added a load-balancing sink processor that uses default round-robin policy to 
select sinks from the group. In case of failure, it skips the sink and goes to 
the next. Can be configured to use random distribution of load instead of 
default round-robin semantics.

Also, this processor accepts implementations of sink selectors which can be 
used to route the load into various sinks. 


This addresses bug FLUME-1198.
    https://issues.apache.org/jira/browse/FLUME-1198


Diffs (updated)
-----

  
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java
 1339941 
  
/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkProcessor.java
 PRE-CREATION 
  
/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkSelector.java
 PRE-CREATION 
  
/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java
 1339941 
  
/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/LoadBalancingSinkProcessor.java
 PRE-CREATION 
  
/trunk/flume-ng-core/src/test/java/org/apache/flume/sink/FixedOrderSelector.java
 PRE-CREATION 
  
/trunk/flume-ng-core/src/test/java/org/apache/flume/sink/SinkProcessorFactoryTest.java
 1339941 
  
/trunk/flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/5161/diff


Testing
-------

Introduced new tests and ran all existing tests. 


Thanks,

Arvind

Reply via email to