[
https://issues.apache.org/jira/browse/FLUME-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279435#comment-13279435
]
[email protected] commented on FLUME-1213:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5166/#review7987
-----------------------------------------------------------
Thanks for the patch Hari. Some feedback follows.
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java
<https://reviews.apache.org/r/5166/#comment17351>
This timestamp will be 0 valued if rounding is disabled. A few test cases
to make sure that the BucketPath is resolving the paths correctly would be a
great help.
flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java
<https://reviews.apache.org/r/5166/#comment17353>
A brief javadoc on what the utility functions accept and return would be
great.
flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java
<https://reviews.apache.org/r/5166/#comment17352>
Internally Calendar uses long timestamp, so would preferable to call
cal.setTimeInMillis(timestamp) instead.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/5166/#comment17348>
please use equalsIgnoreCase("hour") instead.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/5166/#comment17349>
please use equalsIgnoreCase("minute") instead.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/5166/#comment17350>
If the unit is not configured correctly, it will be better to print a
warning and disable rounding altogether.
Also the patch needs to be rebased on the latest sources as it is not applying
cleanly.
- Arvind
On 2012-05-19 02:36:22, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5166/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-19 02:36:22)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Created a utility that does the rounding.
bq.
bq.
bq. This addresses bug FLUME-1213.
bq. https://issues.apache.org/jira/browse/FLUME-1213
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java
da80545
bq.
flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java
PRE-CREATION
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
8ce2bac
bq.
bq. Diff: https://reviews.apache.org/r/5166/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> HDFS sink should allow bucketpath rounding down.
> ------------------------------------------------
>
> Key: FLUME-1213
> URL: https://issues.apache.org/jira/browse/FLUME-1213
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
