> On 2012-05-20 07:26:46, Mike Percy wrote: > > +1 lgtm > > > > Any information on how you found this? Any errors you saw or just saw it in > > your IDE? Thanks.
Mike, thanks for the review. I saw it in the IDE (warning in HDFSEventSink.java) - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5168/#review7993 ----------------------------------------------------------- On 2012-05-20 06:58:00, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5168/ > ----------------------------------------------------------- > > (Updated 2012-05-20 06:58:00) > > > Review request for Flume. > > > Summary > ------- > > ProxyCallable<T> implements Callable<T> now. > > > This addresses bug FLUME-1217. > https://issues.apache.org/jira/browse/FLUME-1217 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > d272f74 > > Diff: https://reviews.apache.org/r/5168/diff > > > Testing > ------- > > Ran build and unit tests. All of them pass. > > > Thanks, > > Hari > >
