----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5188/#review8190 -----------------------------------------------------------
Looks fine, one addition to Hari's comments. flume-ng-core/src/main/java/org/apache/flume/interceptor/TimestampInterceptor.java <https://reviews.apache.org/r/5188/#comment17738> You may also want to check you're not overwriting an existing timestamp header here. While I think it may not be a common use case, I'm sure there will cases where people have stuff coming from multiple sources, some that supply their own stamps. - Juhani On 2012-05-22 01:53:38, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5188/ > ----------------------------------------------------------- > > (Updated 2012-05-22 01:53:38) > > > Review request for Flume. > > > Summary > ------- > > Created a timestamp interceptor that sets the current time as the "timestamp" > header of all events that flow through it. > > > This addresses bug FLUME-1215. > https://issues.apache.org/jira/browse/FLUME-1215 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java > abf2f75 > > flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorBuilderFactory.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/interceptor/TimestampInterceptor.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/interceptor/TestTimestampInterceptor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5188/diff > > > Testing > ------- > > Added unit test. > > > Thanks, > > Mike > >
