----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5333/#review8304 -----------------------------------------------------------
Ship it! +1. Please attach the patch to the jira. - Hari On 2012-06-02 22:31:48, Mubarak Seyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5333/ > ----------------------------------------------------------- > > (Updated 2012-06-02 22:31:48) > > > Review request for Flume. > > > Summary > ------- > > FailoverRpcClient uses batchSize as local variable and it breaks the contract > for getBatchSize(). Consumer of FailoverRpcClient checks for getBatchSize() > to send events using appendBatch(List<Event>), since batchSize is initialized > with null, clients gets NPE. > > The fix is to remove the batchSize local variable in configureHosts() > > > This addresses bug FLUME-1226. > https://issues.apache.org/jira/browse/FLUME-1226 > > > Diffs > ----- > > > trunk/flume-ng-sdk/src/main/java/org/apache/flume/api/FailoverRpcClient.java > 1342144 > > Diff: https://reviews.apache.org/r/5333/diff > > > Testing > ------- > > Tested in lab environment. > > > Thanks, > > Mubarak > >
