[ 
https://issues.apache.org/jira/browse/FLUME-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294770#comment-13294770
 ] 

Nishchay commented on FLUME-1210:
---------------------------------

Can committers please review this patch.
                
> HDFS sink: replace hard-coded configuration names with constants.
> -----------------------------------------------------------------
>
>                 Key: FLUME-1210
>                 URL: https://issues.apache.org/jira/browse/FLUME-1210
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0, v1.2.0
>            Reporter: Mingjie Lai
>            Priority: Minor
>              Labels: patch
>         Attachments: diff.patch
>
>
> Minor issue -- there are tons of hard-coded configuration names in hdfs sink. 
> they should be replaced by constants.
> {code}
>     context.put("hdfs.path", newPath);
>     context.put("hdfs.filePrefix", fileName);
>     context.put("hdfs.txnEventMax", String.valueOf(txnMax));
>     context.put("hdfs.rollCount", String.valueOf(rollCount));
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to