Hi Leslin, Thanks for the feedback. When I wrote the sink, I didn't have enough time to write the tests, and wasn't sure when I would have enough time to do so, which was why I mentioned that we can move it out to the next milestone. There is no inconvenience at all, it is a known fact that more tests and more code coverage is important - and suggestions are always welcome, that's what makes Flume better. I am looking at adding a couple more tests right now. If you can come up with more/better tests, feel free to submit the patches - I will review and check it in.
Thanks, Hari -- Hari Shreedharan On Sunday, June 17, 2012 at 2:28 AM, Leslin wrote: > Hi, Hari, Mike > > HBase sink is quite good and many users want to try it(I polled it in my > group with 4 out of 7 persons). But as HBase sink was published in past > weeks. Testers have limited time to cover this new feature. And Users also > have the same problem to report. When I mentioned this problem, there is > only one case testOneEvent() of this feature. I really hope we can deliver > such a excellent feature in v1.2. So I suggested that whether we can cover > this with more test cases. I am so sorry for this inconvenient. You can > omit it as v1.2 time schedule is tight. I also will help to test it later. > Thanks. > > Best Regards > Leslin > > > 2012/6/17 Mike Percy (JIRA) <[email protected] (mailto:[email protected])> > > > > > [ > > https://issues.apache.org/jira/browse/FLUME-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393495#comment-13393495] > > > > Mike Percy commented on FLUME-1204: > > ----------------------------------- > > > > Hi Hari, > > Leslin mentioned this topic, so I just added the JIRA to the Blocker list. > > > > > Add more unit tests for hbase sink > > > ---------------------------------- > > > > > > Key: FLUME-1204 > > > URL: https://issues.apache.org/jira/browse/FLUME-1204 > > > Project: Flume > > > Issue Type: Bug > > > Components: Sinks+Sources > > > Affects Versions: v1.2.0 > > > Reporter: Hari Shreedharan > > > Priority: Blocker > > > Fix For: v1.2.0 > > > > > > > > > Tentatively marking as v1.2.0 blocker per discussion on flume-dev > > > > -- > > This message is automatically generated by JIRA. > > If you think it was sent incorrectly, please contact your JIRA > > administrators: > > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > > For more information on JIRA, see: http://www.atlassian.com/software/jira > > > > > > -- > > > > Best Regards > > Leslin
