----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5484/#review8460 -----------------------------------------------------------
Ship it! +1. Looks good. Does not strip off stuff now: -Djava.library.path=:/Users/hshreedharan/hadoop-1.0.1/libexec/../lib/native/Mac_OS_X-x86_64-64:/Users/hshreedharan/hadoop-1.0.1/libexec/../lib/native/Mac_OS_X-x86_64-64:/Users/hshreedharan/hbase/hbase-0.92.1/lib/native/Mac_OS_X-x86_64-64 org.apache.flume.node.Application -n agent -f /Users/hshreedharan/Desktop/conf_files/file_channel_null_sink - Hari Shreedharan On June 21, 2012, 12:17 p.m., Will McQueen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5484/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 12:17 p.m.) > > > Review request for Flume and Mike Percy. > > > Description > ------- > > [Copied from FLUME-1303] > > In the flume-ng script, the '\' and 'n' characters are each being treated as > delimiters instead of being treated as a newline character. This relates to > the following line of code that is found in 2 places within the script: > > if [[ $line =~ ^java\.library\.path=([^\n]*) ]]; then > > This causes the java.library.path's value to be truncated at the first '\' or > \n' character in its value. > > For example: > > [will@will-laptop flume-1.2.0-incubating-SNAPSHOT]$ bin/flume-ng agent -d > ...results in a java.library.path of: > -Djava.library.path=:/usr/lib/hadoop/lib/:/ > ..but should be: > -Djava.library.path=:/usr/lib/hadoop/lib/native:/usr/lib/hadoop/lib/native:/usr/lib/hbase/bin/../lib/native/Linux-amd64-64 > > > This addresses bug FLUME-1303. > https://issues.apache.org/jira/browse/FLUME-1303 > > > Diffs > ----- > > bin/flume-ng a45b97c > > Diff: https://reviews.apache.org/r/5484/diff/ > > > Testing > ------- > > Yes, please see FLUME-1303 for complete details. > > > Thanks, > > Will McQueen > >
