-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/
-----------------------------------------------------------

(Updated June 22, 2012, 3:07 p.m.)


Review request for Flume.


Changes
-------

Update code with Will's comment, thanks Will so much!
3) With the new logic, this line is no longer relevant and can be removed:
[ -n "${JAVA_HOME}" ] || error "Unable to find a suitable JAVA_HOME" 1
4) Could you please use the new-style format, to change this:
JAVA_DEFAULT=`type -p java`
...into this:
JAVA_DEFAULT=$(type -p java)


Description
-------

Change flume-ng script to find java from PATH first instead of using 
bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in 
multi-java environment. 


This addresses bug FLUME-1154.
    https://issues.apache.org/jira/browse/FLUME-1154


Diffs (updated)
-----

  bin/flume-ng 24a7d95 

Diff: https://reviews.apache.org/r/5466/diff/


Testing
-------

test with normal start agent


Thanks,

Leslin  (Hong Xiang Lin)

Reply via email to