----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5545/#review8533 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java <https://reviews.apache.org/r/5545/#comment18195> Don't we need to count the success counts here? Null sink may not have to but client app needs to do math like (generated - successful) = dropped_events flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java <https://reviews.apache.org/r/5545/#comment18196> Other sinks (e.g, HBaseSink) counts each txn success/failure like counterGroup.incrementAndGet("transaction.success"); Do we need it here? samething for rollback #90 flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java <https://reviews.apache.org/r/5545/#comment18197> Can we add counterGroup.setName(getName()) here in start()? it helps in debug. - Mubarak Seyed On June 25, 2012, 7:32 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5545/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 7:32 a.m.) > > > Review request for Flume. > > > Description > ------- > > Make Null sink configurable. > > > This addresses bug FLUME-1315. > https://issues.apache.org/jira/browse/FLUME-1315 > > > Diffs > ----- > > > flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java > 6e0ec2b > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java > 0a91436 > flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c812851 > > flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java > 521b586 > > Diff: https://reviews.apache.org/r/5545/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
