----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5404/#review8534 -----------------------------------------------------------
Ship it! lgtm, same as the async test just comment out/ignore the shutdown test and I'll commit it after I finish running the full unit tests - Juhani Connolly On June 25, 2012, 7:24 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5404/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 7:24 a.m.) > > > Review request for Flume. > > > Description > ------- > > Additional unit tests. We can comment out the Hbase failure test before > committing, it takes quite a while to finish. When interested, it can be run > locally by the developer. > > > This addresses bug FLUME-1204. > https://issues.apache.org/jira/browse/FLUME-1204 > > > Diffs > ----- > > > flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java > 6e0ec2b > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java > 0a91436 > flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c812851 > > flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java > 521b586 > > Diff: https://reviews.apache.org/r/5404/diff/ > > > Testing > ------- > > Tested the unit tests by running them. > > > Thanks, > > Hari Shreedharan > >
