> On June 24, 2012, 8:32 p.m., Ralph Goers wrote: > > I tried applying your patch. I got an error. One of the changes to > > bin/flume-ng already seems to be present. When I run mvn package > > -DskipTests I get > > > > [INFO] --- exec-maven-plugin:1.2.1:exec (generate-version) @ flume-ng-core > > --- > > scripts/saveVersion.sh: line 33: ../: is a directory > > scripts/saveVersion.sh: line 48: md5sum: command not found > > xargs: md5sum: No such file or directory > > > > Are you expecting md5sum to be present? Is it required? > > > > I did not have an error with missing dependencies. > > Leslin (Hong Xiang Lin) wrote: > Hi, Ralph > md5sum is saved into version info annotation file and provide thru API. > it will not print to console by command like flume-ng version. We can > discuss whether provide md5sum info or not. Hadoop and Hbase provide this > info thru API. > > Regards > Leslin
Sorry, Ralph, I double check that md5sum will print to console now. But it's easy to delete in VersionInfo.main(). - Leslin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5463/#review8520 ----------------------------------------------------------- On June 25, 2012, 2:20 p.m., Leslin (Hong Xiang Lin) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5463/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 2:20 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add feature to let flume-ng get version info: > eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version > Apache Flume version: 1.2.0-incubating-SNAPSHOT > Built-By: 1.2.0-incubating-SNAPSHOT > > > This addresses bug FLUME-1240. > https://issues.apache.org/jira/browse/FLUME-1240 > > > Diffs > ----- > > bin/flume-ng 43d1766 > flume-ng-core/pom.xml e4c8104 > flume-ng-core/scripts/saveVersion.sh PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/VersionAnnotation.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5463/diff/ > > > Testing > ------- > > Test with: > flume-ng version > flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties > > > Thanks, > > Leslin (Hong Xiang Lin) > >
