----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5551/#review8561 -----------------------------------------------------------
/trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java <https://reviews.apache.org/r/5551/#comment18240> FileChannelConfiguration has a constant public static final long DEFAULT_MAX_FILE_SIZE = LogFile.MAX_FILE_SIZE; Can't we make use of that constant in LogFile? Now, we have two constants and both refers same value. If it is a too much of code change (i think TestLog code refers LogFile.MAX_FILE_SIZE), can we define the contant value in FileChannelConfiguration.DEFAULT_MAX_FILE_SIZE and refer it as LogFile.MAX_FILE_SIZE = FileChannelConfiguration.DEFAULT_MAX_FILE_SIZE? I guess both are same but FileChannelConfiguration is meant to define default values. Looks like LogFile.MAX_FILE_SIZE = Integer.MAX_VALUE - (500L * 1024L * 1024L) is a default value? - Mubarak Seyed On June 25, 2012, 5:21 p.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5551/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 5:21 p.m.) > > > Review request for Flume and Brock Noland. > > > Description > ------- > > Currently the file channel log file can grow beyond the maximum size under > load due to non locking size check semantics. These semantics are good in > that they allow for higher concurrency rather than having exclusive access to > the writer thread between size check and write. Therefore the better fix is > to allow for minor size breach with warnings. > > This change modifies the code to relax the assertion that checks file size to > warning. Also, increased the log write default timeout from 3s to 10s. > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 1353634 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1353634 > > Diff: https://reviews.apache.org/r/5551/diff/ > > > Testing > ------- > > Ran full tests. > > > Thanks, > > Arvind Prabhakar > >
