----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5577/#review8583 -----------------------------------------------------------
Ship it! +1 lgtm. Again, Brock - if you have any concerns please raise them and I'll follow up on it. - Mike Percy On June 26, 2012, 8:19 a.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5577/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 8:19 a.m.) > > > Review request for Flume and Mike Percy. > > > Description > ------- > > This change introduces a new header in the checkpoint file which allows > tracking of incomplete checkpoint syncs. In case the checkpoint is > incomplete, the startup will fail with an exception suggesting that the > checkpoint be rebuilt. > > Also included in this patch are changes to exception messages so that the > channel name gets propagated with the messages. This is very useful when > debugging configurations where there are more than one file channel > configured within the system. > > > This addresses bug FLUME-1320. > https://issues.apache.org/jira/browse/FLUME-1320 > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpoint.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 1353852 > > /trunk/flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java > 1353852 > > Diff: https://reviews.apache.org/r/5577/diff/ > > > Testing > ------- > > Ran all tests. > > > Thanks, > > Arvind Prabhakar > >
