----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5584/#review8585 -----------------------------------------------------------
Ship it! +1 lgtm - Mike Percy On June 26, 2012, 12:13 p.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5584/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 12:13 p.m.) > > > Review request for Flume and Mike Percy. > > > Description > ------- > > The change fixes the implementation to use position instead of size as was > previously being done. This should take care of the unassigned blocks > reported in the issue. > > > This addresses bug FLUME-1324. > https://issues.apache.org/jira/browse/FLUME-1324 > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 1353937 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1353937 > > Diff: https://reviews.apache.org/r/5584/diff/ > > > Testing > ------- > > Ran all tests. Verified manually that the log files are integral for a large > fully populated channel of size 1M. > > > Thanks, > > Arvind Prabhakar > >
